-
Notifications
You must be signed in to change notification settings - Fork 119
feat: support inferencepool v1 #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I won't review until the upstream API PR lands: kubernetes-sigs/gateway-api-inference-extension#1173 |
Signed-off-by: bitliu <[email protected]>
|
Can we plan this effort in the next work? |
|
@johnugeorge sure, will schedule sometime to finish this next week |
|
after this lands, we should raise a PR to https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/conformance/reports/v1.0.0/gateway |
|
Yes for sure |
|
@Xunzhuo kindly ping |
|
will redo this PR after #1239 |
|
ping @Xunzhuo |
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
|
@Xunzhuo resolved the huge conflicts for you! I think it should be good to go |
|
what! cool @mathetake haha, i was scheduling to resolve this at this week, but if it is good to go, let us move this forward |
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
|
ah i think the documentation change also needed |
Signed-off-by: bitliu <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (77.56%) is below the target coverage (86.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
=======================================
Coverage 77.56% 77.56%
=======================================
Files 123 123
Lines 15768 15759 -9
=======================================
- Hits 12230 12224 -6
+ Misses 2908 2906 -2
+ Partials 630 629 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
|
i think this is good to go, the ext-proc e2e is not related to this PR(broken by mcp tests) |
site/docs/capabilities/inference/aigatewayroute-inferencepool.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
**Description** This PR is to add v1 inferencepool support **Related Issues/PRs (if applicable)** Fixes envoyproxy#1032 --------- Signed-off-by: bitliu <[email protected]> Co-authored-by: Takeshi Yoneda <[email protected]> Signed-off-by: Hrushikesh Patil <[email protected]>
**Description** This PR is to add v1 inferencepool support **Related Issues/PRs (if applicable)** Fixes envoyproxy#1032 --------- Signed-off-by: bitliu <[email protected]> Co-authored-by: Takeshi Yoneda <[email protected]> Signed-off-by: Hrushikesh Patil <[email protected]>
**Description** This PR is to add v1 inferencepool support **Related Issues/PRs (if applicable)** Fixes envoyproxy#1032 --------- Signed-off-by: bitliu <[email protected]> Co-authored-by: Takeshi Yoneda <[email protected]> Signed-off-by: Hrushikesh Patil <[email protected]>
Description
This PR is to add v1 inferencepool support
Related Issues/PRs (if applicable)
Fixes #1032